-
Notifications
You must be signed in to change notification settings - Fork 6k
Improve contravariance example in "Using Variance in Delegates" documentation #47052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot finished work on behalf of
BillWagner
July 1, 2025 18:09
BillWagner
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start. I have a few suggestions for improvement.
.../covariance-contravariance/snippets/using-variance-in-delegates/ContravarianceExample.csproj
Outdated
Show resolved
Hide resolved
...epts/covariance-contravariance/snippets/using-variance-in-delegates/ContravarianceExample.cs
Outdated
Show resolved
Hide resolved
...epts/covariance-contravariance/snippets/using-variance-in-delegates/ContravarianceExample.cs
Outdated
Show resolved
Hide resolved
...epts/covariance-contravariance/snippets/using-variance-in-delegates/ContravarianceExample.cs
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/concepts/covariance-contravariance/using-variance-in-delegates.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/concepts/covariance-contravariance/using-variance-in-delegates.md
Outdated
Show resolved
Hide resolved
…lock syntax, remove unnecessary console output Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot finished work on behalf of
BillWagner
July 2, 2025 13:39
BillWagner
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for final review.
IEvangelist
approved these changes
Jul 2, 2025
docs/csharp/programming-guide/concepts/covariance-contravariance/using-variance-in-delegates.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/concepts/covariance-contravariance/using-variance-in-delegates.md
Outdated
Show resolved
Hide resolved
…rify custom types Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot finished work on behalf of
IEvangelist
July 2, 2025 14:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing contravariance example in the "Using Variance in Delegates" documentation was causing confusion for users who couldn't understand how the
MultiHandler
method could handle bothKeyDown
andMouseClick
events.Changes Made
1. Created Complete Working Example
snippets/using-variance-in-delegates/ContravarianceExample.cs
KeyEventArgs
andMouseEventArgs
classesMultiHandler
method handles multiple event types2. Enhanced Documentation
EventArgs
parameter to handle events expecting more specific types3. Improved Code Organization
Example Output
The new example produces clear output demonstrating the concept:
This directly addresses the user's confusion by showing exactly how contravariance enables one handler to work with multiple event types, making the documentation much clearer and more educational.
Fixes #18540.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews